Conversation
toastal
force-pushed
the
devicepixelratio
branch
from
b031226 to
0a5936e
Compare
thomashoneyman
left a comment
thomashoneyman
left a comment
There was a problem hiding this comment.
Technically, this function ought to go in purescript-web-cssom, but given its similarity to scrollX / scrollY and their existence here I think it's acceptable to merge here. We will at some point have to sweep back through the specs to migrate functions appropriately but there's not a concrete timeline for that.
|
(That said, given that we're making breaking changes as part of the updates for PureScript 0.14, we may want to go ahead and move other functions like |
|
I opened a comment on the cssom repo, it maybe shouldn't belong there either, it's defined in the cssom-view spec: https://www.w3.org/TR/cssom-view-1/#extensions-to-the-window-interface |
|
Would there be a downside to have it duplicated in two places? People could possibly be looking for it in either?? I dunno.. |
3 participants
Prerequisites
purescript-webprojects. Although MDN is a great resource, it is not a suitable reference for this project.Description
According to the spec, this,
devicePixelRatio, is under CSSOM. There exists apurescript-cssomlibrary, however, other functions likescrollBy,scrollTo, etc. are also listed under CSSOM, but are in theWeb.HTMLlibrary so I guess this should go here??